Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where search unindexed items wasn't clickable #12245

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

ZLAllen
Copy link
Contributor

@ZLAllen ZLAllen commented Apr 30, 2023

Resolved / Related Issues

Description
Moved the hyperlink button after the SemanticZoom control to allow tap event to invoke the command. This also helps keep the control center in the window.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm the hyperlink button in DetailsLayoutBrowser is clickable and the binding command is invoked
    2. Confirm the search unindexed items hyperkink works as expected in GridViewBrowser

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fixes search unindexed items not acting like a button (#12085) Fix: Fixed issue where search unindexed items wasn't clickable Apr 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Congratulations on your first pull request.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 30, 2023
@yaira2 yaira2 merged commit c73c9cc into files-community:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Search result button to search unindexed items is not clickable
2 participants